jakob/friendica
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity
14586 commits 10 branches 58 tags 216 MiB
Commit graph

14586 commits

This branch
This branch
All branches
Author SHA1 Message Date
Roland Haeder
67707247c8
Continued: 
- added curly braces/spaces
- changed lower-case SQL keywords to upper-case
- used dbm::is_result() instead of count() (avoids warning in case of false is
  returned)

Signed-off-by: Roland Haeder <roland@mxchange.org>
 2017-03-25 13:15:42 +01:00
Roland Haeder
c1287df655
removed old-lost code + internal TODO closed 
Signed-off-by: Roland Haeder <roland@mxchange.org>
 2017-03-25 13:12:41 +01:00
Roland Haeder
fd468f20fd
merged 2 if() into one, closes internal TODO 
Signed-off-by: Roland Haeder <roland@mxchange.org>
 2017-03-25 13:08:56 +01:00
Roland Haeder
47ae5a9a47
removed parentheses, added curly ... 
Signed-off-by: Roland Haeder <roland@mxchange.org>
 2017-03-25 13:07:33 +01:00
Roland Haeder
2f5c796886
removed TODO, one day this all needs refacturizing ... 
Signed-off-by: Roland Haeder <roland@mxchange.org>
 2017-03-25 13:02:09 +01:00
Roland Haeder
1514fdaead
rewrote to static approach and if() condition can be simplified. 
Signed-off-by: Roland Haeder <roland@mxchange.org>
 2017-03-25 13:00:10 +01:00
Roland Haeder
d64dafec63
removed parentheses and indended it for better readability 
Signed-off-by: Roland Haeder <roland@mxchange.org>
 2017-03-25 12:55:39 +01:00
Roland Haeder
bd4cee8c21
added spaces/curly braces and TODO for better using trim() 
Signed-off-by: Roland Haeder <roland@mxchange.org>
 2017-03-25 12:53:48 +01:00
Roland Haeder
a70a2381c9
removed old-lost code 
Signed-off-by: Roland Haeder <roland@mxchange.org>
 2017-03-25 12:49:17 +01:00
Roland Haeder
506af8b556
changed "and" -> && according to CR 
Signed-off-by: Roland Haeder <roland@mxchange.org>
 2017-03-25 12:47:47 +01:00
Roland Haeder
689b81171e
added spaces, removed parentheses. there is more ahead than just this one. 
Signed-off-by: Roland Haeder <roland@mxchange.org>
 2017-03-25 12:44:24 +01:00
Roland Haeder
566cfb8418
space-time season continues ... 
Signed-off-by: Roland Haeder <roland@mxchange.org>
 2017-03-24 22:45:09 +01:00
Roland Haeder
239dfea4e6
it is space-time! ;-) 
Signed-off-by: Roland Haeder <roland@mxchange.org>
 2017-03-24 22:40:33 +01:00
Roland Haeder
caad9f5214
added more spaces (CR request) 
Signed-off-by: Roland Haeder <roland@mxchange.org>
 2017-03-24 22:36:52 +01:00
Roland Haeder
be717649a4
added more curly braces/spaces 
Signed-off-by: Roland Haeder <roland@mxchange.org>
 2017-03-24 22:34:13 +01:00
Roland Haeder
daa32d49cf
killme() does the same here + added curly braces 
Signed-off-by: Roland Haeder <roland@mxchange.org>
 2017-03-24 21:19:37 +01:00
Roland Haeder
c0be733d6d
Opps, became lazy here, thanks to @Hypolite finding it. 
Signed-off-by: Roland Haeder <roland@mxchange.org>
 2017-03-24 21:15:36 +01:00
Roland Haeder
084dbd6859
Continued: 
- some spaces added
- removed parentheses as requested by @Hypolite
- added really important TODO as remote-inclusion is not what you want

Signed-off-by: Roland Haeder <roland@mxchange.org>
 2017-03-24 21:11:21 +01:00
Roland Haeder
0e19fdfc71
removed parentheses + added TODO about a small rewrite 
Signed-off-by: Roland Haeder <roland@mxchange.org>
 2017-03-24 21:05:55 +01:00
Roland Haeder
b5b3451b31
Continued: 
- marked commented-out code as possible old-lost
- added more curly braces
- used more dbm::is_result() where SELECT is stated
- ! added quotes in array element, else (here) >thumb< (without quotes) is
  considered as a constant and causes an E_NOTICE

Signed-off-by: Roland Haeder <roland@mxchange.org>
 2017-03-24 20:57:52 +01:00
Roland Haeder
ccd1e2cc6a
fixed parser error 
Signed-off-by: Roland Haeder <roland@mxchange.org>
 2017-03-24 20:52:26 +01:00
Roland Haeder
d45e79dfe9
Continued: 
- converted multiple single-line comments into one multi-line comment (please
  stop abusing programming languages!)
- added more TODO tags for type-hints (upcoming rewrite)
- opps, one space was only fixed in develop branch, not in this PR branch

Signed-off-by: Roland Haeder <roland@mxchange.org>
 2017-03-24 20:39:00 +01:00
Roland Haeder
db1c2e4041
fixed comment and explained one 
Signed-off-by: Roland Haeder <roland@mxchange.org>
 2017-03-23 23:37:58 +01:00
Roland Haeder
a410f86e9c
Continued with #3254: 
- added curly braces + spaces
- converted multiple single-line comments to one multi-line comment

Signed-off-by: Roland Haeder <roland@mxchange.org>
 2017-03-23 23:08:40 +01:00
Roland Haeder
c4b82133e9
added more curly braces + spaces for #3254 
Signed-off-by: Roland Haeder <roland@mxchange.org>
 2017-03-23 23:06:28 +01:00
Roland Haeder
2470930902
Continued #3254: 
- thrown out old lost-code
- add curly braces (not curely ;-) ) and spaces
- exit is not a keyword, it is a function, so use () here

Signed-off-by: Roland Haeder <roland@mxchange.org>
 2017-03-23 23:02:25 +01:00
Roland Haeder
e4ad359f5a
added curely braces + TODO for maybe avoiding multi-lined if() blocks as it confuses #3254 
Signed-off-by: Roland Haeder <roland@mxchange.org>
 2017-03-23 22:53:03 +01:00
Roland Haeder
f94a10bf00
old behaviour restored 
Signed-off-by: Roland Haeder <roland@mxchange.org>
 2017-03-23 22:49:34 +01:00
Roland Haeder
66366b2804
added more spaces and curely braces 
killed ?> as it is discouraged

Signed-off-by: Roland Haeder <roland@mxchange.org>
 2017-03-23 22:46:25 +01:00
Roland Haeder
d8eee2be55
added curely branches + reverted back to old behaviour (may come back one day) 
Signed-off-by: Roland Haeder <roland@mxchange.org>
 2017-03-23 22:33:57 +01:00
Roland Haeder
09ab141404
better comment added by @Hypolite 
Signed-off-by: Roland Haeder <roland@mxchange.org>
 2017-03-23 22:29:26 +01:00
Roland Haeder
16c405b387
more spaces added (CR by @Hypolite) 
Signed-off-by: Roland Haeder <roland@mxchange.org>
 2017-03-23 22:22:41 +01:00
Roland Haeder
dad6a61be4
it is space-season ... ;-) #3254 
Signed-off-by: Roland Haeder <roland@mxchange.org>
 2017-03-23 22:19:25 +01:00
Roland Haeder
843b7a003c
closed internal TODO, merged 2 if() to one + added spaces 
Signed-off-by: Roland Haeder <roland@mxchange.org>
 2017-03-23 22:17:39 +01:00
Roland Haeder
11d3fd163a
yet another one removed, thanks to @Hypolite for CR 
Signed-off-by: Roland Haeder <roland@mxchange.org>
 2017-03-23 22:13:28 +01:00
Roland Haeder
480871d371
removed no longer old stuff, let's don't stuff code with commented-out code 
Signed-off-by: Roland Haeder <roland@mxchange.org>
 2017-03-23 22:11:58 +01:00
Roland Haeder
9521f39ebe
added more spaces #3254 
Signed-off-by: Roland Haeder <roland@mxchange.org>
 2017-03-23 22:09:15 +01:00
Roland Haeder
f85e6d2aac
No parantheses here + no @ (which surpresses warnings and such) #3254 
Signed-off-by: Roland Haeder <roland@mxchange.org>
 2017-03-23 21:47:51 +01:00
Roland Haeder
47602577f3
Opps, missed one ... 
Signed-off-by: Roland Haeder <roland@mxchange.org>
 2017-03-23 21:45:00 +01:00
Roland Haeder
221cfa8c22
added curly braces #3254 
Signed-off-by: Roland Haeder <roland@mxchange.org>
 2017-03-23 21:44:01 +01:00
Roland Haeder
f5227c016d
replaced some tabs -> spaces + added curly braces #3254 
Signed-off-by: Roland Haeder <roland@mxchange.org>
 2017-03-23 21:28:32 +01:00
Roland Häder
f173322539
added missing spaces/curly braces 
Signed-off-by: Roland Häder <roland@mxchange.org>
 2017-03-21 21:52:00 +01:00
Roland Häder
ddb5a8ea78
Continued: 
- added missing space/curly braces
- added TODOs for later adding a lot type-hints, without these (and they are
  long time around in PHP) anything can be handled over to the method/function.

Signed-off-by: Roland Häder <roland@mxchange.org>
 2017-03-21 21:51:22 +01:00
Roland Häder
830af774d3
added more curly braces + a bit more usage of dbm::is_result() 
Signed-off-by: Roland Häder <roland@mxchange.org>
 2017-03-21 21:50:45 +01:00
Hypolite Petovan
61a01141d7 Merge pull request #3253 from friendica/revert-3112-rewrites/coding-convention 
Revert "Coding convention applied - part 1"
 2017-03-21 12:04:19 -04:00
Hypolite Petovan
7b352f3f74 Revert "Coding convention applied - part 1" 2017-03-21 12:02:59 -04:00
Hypolite Petovan
9c2c483996 Merge pull request #3112 from Quix0r/rewrites/coding-convention 
Coding convention applied - part 1
 2017-03-21 10:19:53 -04:00
Tobias Diekershoff
0fd874a683 Merge pull request #3246 from annando/1701-poco 
Split poco discovery in smaller function calls
 2017-03-21 07:27:10 +01:00
Roland Haeder
09851331a9
Merge remote-tracking branch 'upstream/develop' into rewrites/coding-convention 
Signed-off-by: Roland Haeder <roland@mxchange.org>
 2017-03-20 20:51:32 +01:00
Hypolite Petovan
7a95fcf02a Merge pull request #3241 from rabuzarus/20170316_-_fix_event_edit 
add dop event & fix event edit
 2017-03-20 13:18:18 -04:00