From f86b354744651cddf766a7532805b90d806eda08 Mon Sep 17 00:00:00 2001 From: Tommi Virtanen Date: Wed, 29 Aug 2007 22:28:53 -0700 Subject: [PATCH] Refactor unit test writeFile/readFile helpers. --- gitosis/test/test_ssh.py | 18 ++---------------- gitosis/test/util.py | 17 +++++++++++++++++ 2 files changed, 19 insertions(+), 16 deletions(-) diff --git a/gitosis/test/test_ssh.py b/gitosis/test/test_ssh.py index 8fe18c9..3b29310 100644 --- a/gitosis/test/test_ssh.py +++ b/gitosis/test/test_ssh.py @@ -4,16 +4,7 @@ import os from cStringIO import StringIO from gitosis import ssh -from gitosis.test.util import mkdir, maketemp - -def writeFile(path, content): - tmp = '%s.tmp' % path - f = file(tmp, 'w') - try: - f.write(content) - finally: - f.close() - os.rename(tmp, path) +from gitosis.test.util import mkdir, maketemp, writeFile, readFile def _key(s): return ''.join(s.split('\n')).strip() @@ -174,12 +165,7 @@ baz ssh.writeAuthorizedKeys( path=path, keydir=keydir) - f = file(path) - try: - got = f.read() - finally: - f.close() - + got = readFile(path) eq(got, '''\ # foo bar diff --git a/gitosis/test/util.py b/gitosis/test/util.py index fa3a2be..a56de28 100644 --- a/gitosis/test/util.py +++ b/gitosis/test/util.py @@ -16,3 +16,20 @@ def maketemp(): tmp = os.path.join(tmp, me) mkdir(tmp) return tmp + +def writeFile(path, content): + tmp = '%s.tmp' % path + f = file(tmp, 'w') + try: + f.write(content) + finally: + f.close() + os.rename(tmp, path) + +def readFile(path): + f = file(path) + try: + data = f.read() + finally: + f.close() + return data