Make error messages harder to confuse with strerror(3).
This commit is contained in:
parent
70dbe1dfca
commit
3c2963b777
|
@ -56,13 +56,13 @@ class UnsafeArgumentsError(ServingError):
|
||||||
"""Arguments to command look dangerous"""
|
"""Arguments to command look dangerous"""
|
||||||
|
|
||||||
class AccessDenied(ServingError):
|
class AccessDenied(ServingError):
|
||||||
"""Access denied"""
|
"""Access denied to repository"""
|
||||||
|
|
||||||
class WriteAccessDenied(AccessDenied):
|
class WriteAccessDenied(AccessDenied):
|
||||||
"""Write access denied"""
|
"""Repository write access denied"""
|
||||||
|
|
||||||
class ReadAccessDenied(AccessDenied):
|
class ReadAccessDenied(AccessDenied):
|
||||||
"""Read access denied"""
|
"""Repository read access denied"""
|
||||||
|
|
||||||
def serve(
|
def serve(
|
||||||
cfg,
|
cfg,
|
||||||
|
|
|
@ -54,7 +54,7 @@ def test_bad_forbiddenCommand_read():
|
||||||
user='jdoe',
|
user='jdoe',
|
||||||
command="git-upload-pack 'foo'",
|
command="git-upload-pack 'foo'",
|
||||||
)
|
)
|
||||||
eq(str(e), 'Read access denied')
|
eq(str(e), 'Repository read access denied')
|
||||||
assert isinstance(e, serve.AccessDenied)
|
assert isinstance(e, serve.AccessDenied)
|
||||||
assert isinstance(e, serve.ServingError)
|
assert isinstance(e, serve.ServingError)
|
||||||
|
|
||||||
|
@ -69,7 +69,7 @@ def test_bad_forbiddenCommand_write_noAccess():
|
||||||
)
|
)
|
||||||
# error message talks about read in an effort to make it more
|
# error message talks about read in an effort to make it more
|
||||||
# obvious that jdoe doesn't have *even* read access
|
# obvious that jdoe doesn't have *even* read access
|
||||||
eq(str(e), 'Read access denied')
|
eq(str(e), 'Repository read access denied')
|
||||||
assert isinstance(e, serve.AccessDenied)
|
assert isinstance(e, serve.AccessDenied)
|
||||||
assert isinstance(e, serve.ServingError)
|
assert isinstance(e, serve.ServingError)
|
||||||
|
|
||||||
|
@ -85,7 +85,7 @@ def test_bad_forbiddenCommand_write_readAccess():
|
||||||
user='jdoe',
|
user='jdoe',
|
||||||
command="git-receive-pack 'foo'",
|
command="git-receive-pack 'foo'",
|
||||||
)
|
)
|
||||||
eq(str(e), 'Write access denied')
|
eq(str(e), 'Repository write access denied')
|
||||||
assert isinstance(e, serve.AccessDenied)
|
assert isinstance(e, serve.AccessDenied)
|
||||||
assert isinstance(e, serve.ServingError)
|
assert isinstance(e, serve.ServingError)
|
||||||
|
|
||||||
|
|
Loading…
Reference in a new issue