jakob/friendica
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

cache result of (expensive) security check for visitor rights

Browse source 
begin tightening x-profile security
This commit is contained in:
Friendika 2010-12-02 21:09:55 -08:00
parent 041933db87
commit 4d84a87ce4
3 changed files with 37 additions and 30 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

24
include/security.php
View file

@ -2,8 +2,11 @@
function can_write_wall(&$a,$owner) {
static $verified = 0;
if((! (local_user())) && (! (remote_user())))
return false;
$uid = local_user();
if(($uid) && ($uid == $owner)) {
@ -11,6 +14,15 @@ function can_write_wall(&$a,$owner) {
}
if(remote_user()) {
// user remembered decision and avoid a DB lookup for each and every display item
// DO NOT use this function if there are going to be multiple owners
if($verified === 2)
return true;
elseif($verified === 1)
return false;
else {
$r = q("SELECT `contact`.*, `user`.`page-flags` FROM `contact` LEFT JOIN `user` on `user`.`uid` = `contact`.`uid`
WHERE `contact`.`uid` = %d AND `contact`.`id` = %d AND `contact`.`blocked` = 0 AND `contact`.`pending` = 0
AND `readonly` = 0 AND ( `contact`.`rel` IN ( %d , %d ) OR `user`.`page-flags` = %d ) LIMIT 1",
@ -20,11 +32,15 @@ function can_write_wall(&$a,$owner) {
intval(REL_BUD),
intval(PAGE_COMMUNITY)
);
}
if(count($r))
if(count($r)) {
$verified = 2;
return true;
}
else {
$verified = 1;
}
}
}
return false;
}

25
mod/dfrn_poll.php
View file

@ -10,6 +10,7 @@ function dfrn_poll_init(&$a) {
$type = ((x($_GET,'type')) ? $_GET['type'] : '');
$last_update = ((x($_GET,'last_update')) ? $_GET['last_update'] : '');
$destination_url = ((x($_GET,'destination_url')) ? $_GET['destination_url'] : '');
$sec = ((x($_GET,'sec')) ? intval($_GET['sec']) : 0);
$dfrn_version = ((x($_GET,'dfrn_version')) ? (float) $_GET['dfrn_version'] : 0);
@ -212,18 +213,11 @@ function dfrn_poll_post(&$a) {
function dfrn_poll_content(&$a) {
$dfrn_id = '';
$type = 'data';
if(x($_GET,'dfrn_id'))
$dfrn_id = $_GET['dfrn_id'];
if(x($_GET,'type'))
$type = $_GET['type'];
if(x($_GET,'last_update'))
$last_update = $_GET['last_update'];
$dfrn_version = (float) $_GET['dfrn_version'];
$dfrn_id = ((x($_GET,'dfrn_id')) ? $_GET['dfrn_id'] : '');
$type = ((x($_GET,'type')) ? $_GET['type'] : 'data');
$last_update = ((x($_GET,'last_update')) ? $_GET['last_update'] : '');
$dfrn_version = ((x($_GET,'dfrn_version')) ? (float) $_GET['dfrn_version'] : 2.0);
$sec = ((x($_GET,'sec')) ? intval($_GET['sec']) : 0);
$direction = (-1);
if(strpos($dfrn_id,':') == 1) {
@ -249,7 +243,6 @@ function dfrn_poll_content(&$a) {
dbesc($last_update)
);
$sql_extra = '';
switch($direction) {
case (-1):
@ -269,9 +262,6 @@ function dfrn_poll_content(&$a) {
break; // NOTREACHED
}
$r = q("SELECT * FROM `contact` WHERE `blocked` = 0 AND `pending` = 0 $sql_extra LIMIT 1");
if(count($r)) {
@ -296,10 +286,11 @@ function dfrn_poll_content(&$a) {
else {
$status = 1;
}
header("Content-type: text/xml");
echo '<?xml version="1.0" encoding="UTF-8"?>' . "\r\n"
. '<dfrn_poll>' . "\r\n"
. "\t" . '<status>' .$status . '</status>' . "\r\n"
. "\t" . '<status>' . $status . '</status>' . "\r\n"
. "\t" . '<dfrn_version>' . DFRN_PROTOCOL_VERSION . '</dfrn_version>' . "\r\n"
. "\t" . '<dfrn_id>' . $encrypted_id . '</dfrn_id>' . "\r\n"
. "\t" . '<challenge>' . $challenge . '</challenge>' . "\r\n"

2
mod/redir.php
View file

@ -27,6 +27,6 @@ function redir_init(&$a) {
dbesc($dfrn_id),
intval(time() + 45));
goaway ($r[0]['poll'] . '?dfrn_id=' . $dfrn_id
. '&dfrn_version=' . DFRN_PROTOCOL_VERSION . '&type=profile');
. '&dfrn_version=' . DFRN_PROTOCOL_VERSION . '&type=profile&sec=1');
}